Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663573002: Fix Java indentation issues. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Java indentation issues. Fix indentation issues to allow enabling Checkstyle indentation rule. BUG=318404 Committed: https://crrev.com/a49e9faf5eb9f5fe417ce6470bb58f95d2a7261e Cr-Commit-Position: refs/heads/master@{#299975}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -479 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwCookieManager.java View 1 chunk +4 lines, -6 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwZoomControls.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 34 chunks +76 lines, -79 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java View 9 chunks +24 lines, -23 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 10 chunks +28 lines, -28 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java View 25 chunks +62 lines, -62 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java View 3 chunks +13 lines, -15 lines 1 comment Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 40 chunks +133 lines, -115 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 3 chunks +12 lines, -12 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java View 6 chunks +11 lines, -12 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java View 1 chunk +7 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/AwQuotaManagerBridgeTestUtil.java View 1 chunk +6 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/CommonResources.java View 3 chunks +35 lines, -35 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 2 chunks +7 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestUtil.java View 2 chunks +11 lines, -11 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/DrawGL.java View 1 chunk +6 lines, -6 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 3 chunks +3 lines, -2 lines 0 comments Download
M android_webview/unittestjava/src/org/chromium/android_webview/unittest/MockAwContentsClientBridge.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
boliu: PTAL
6 years, 2 months ago (2014-10-16 18:52:47 UTC) #2
boliu
lgtm We need clang-format for java... https://codereview.chromium.org/663573002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java (right): https://codereview.chromium.org/663573002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java#newcode109 android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java:109: }); This one ...
6 years, 2 months ago (2014-10-16 19:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663573002/1
6 years, 2 months ago (2014-10-16 20:22:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 21:10:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:11:31 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a49e9faf5eb9f5fe417ce6470bb58f95d2a7261e
Cr-Commit-Position: refs/heads/master@{#299975}

Powered by Google App Engine
This is Rietveld 408576698