Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663563002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
davidben
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, cmumford, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dgrogan, feature-media-reviews_chromium.org, horo+watch_chromium.org, jam, jbauman+watch_chromium.org, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+serviceworker, michaeln, miu+watch_chromium.org, nasko+codewatch_chromium.org, nhiroki, piman+watch_chromium.org, serviceworker-reviews, sievers+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/923ac874a9cddf888f3ceb902bc9e5aa1445567e Cr-Commit-Position: refs/heads/master@{#300128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -50 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 18:40:44 UTC) #2
davidben
lgtm
6 years, 2 months ago (2014-10-17 17:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663563002/1
6 years, 2 months ago (2014-10-17 17:42:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 17:56:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:58:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/923ac874a9cddf888f3ceb902bc9e5aa1445567e
Cr-Commit-Position: refs/heads/master@{#300128}

Powered by Google App Engine
This is Rietveld 408576698