Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2793)

Unified Diff: base/BUILD.gn

Issue 663543003: Fix low-memory devices crashing on Chrome start up during UMA recodring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Large update for review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 18f2b017d41e28d813cb294d93a9a3e268aa3769..51c468378eb14be1d9d246160f43b8a713d7a95e 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -55,6 +55,7 @@ component("base") {
"android/jni_weak_ref.h",
"android/library_loader/library_loader_hooks.cc",
"android/library_loader/library_loader_hooks.h",
+ "android/library_loader/library_load_from_apk_support_code.h",
rmcilroy 2014/10/20 10:42:39 "support_code" sounds like it is code to add suppo
petrcermak 2014/10/20 15:33:22 Done. I changed the histogram too.
"android/memory_pressure_listener_android.cc",
"android/memory_pressure_listener_android.h",
"android/java_handler_thread.cc",
@@ -1413,6 +1414,7 @@ if (is_android) {
android_library("base_java") {
srcjar_deps = [
":base_java_application_state",
+ ":base_java_library_load_from_apk_support_code",
":base_java_memory_pressure_level_list",
":base_native_libraries_gen",
]
@@ -1431,6 +1433,18 @@ if (is_android) {
]
}
+ # GYP: //base.gyp:base_java_library_load_from_apk_support_code
+ java_cpp_template("base_java_library_load_from_apk_support_code") {
+ sources = [
+ "android/java/src/org/chromium/base/library_loader/LibraryLoadFromApkSupportCode.template",
rmcilroy 2014/10/20 10:42:39 I think you've forgotten to upload this file ;).
petrcermak 2014/10/20 15:33:22 Done (I'd forgotten the file below as well).
+ ]
+ inputs = [
+ "android/library_loader/library_load_from_apk_support_code.h"
+ ]
+
+ package_name = "org/chromium/base/library_loader"
+ }
+
# GYP: //base.gyp:base_javatests
android_library("base_javatests") {
deps = [

Powered by Google App Engine
This is Rietveld 408576698