Mojo: RemotePtr<S> + bindings changes for Peer attribute.

mojo/public/bindings/generators/mojom_cpp_generator.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates C++ source files from a mojom.Module."""
 
 import datetime
 import mojom
 import mojom_pack
 import os
@@ skipping 290 matching lines @@
     return '\n'.join(struct_decls)
 
   def GetInterfaceClassDeclaration(self, interface, template, method_postfix):
     methods = []
     for method in interface.methods:
       params = []
       for param in method.parameters:
         params.append("%s %s" % (self.GetConstType(param.kind), param.name))
       methods.append(
           "  virtual void %s(%s) %s;" %
               (method.name, ", ".join(params), method_postfix))

[DaveMoore, 2013/11/11 18:49:05]

Since this ends up being a statically defined thing, I find it strange that it's
defined through a dynamic attribute format. Why not express it as a top level
construct. I'd imagine anything defined through a dynamic mechanism to end up as
a dynamic bag of properties that could be interrogated through a C++ api.

+    peer = interface.attributes['Peer']
     return template.substitute(
         CLASS=interface.name,
-        METHODS='.\n'.join(methods))
+        PEER=peer,
+        METHODS='\n'.join(methods))
 
   def GetInterfaceClassDeclarations(self):
     template = self.GetTemplate("interface_declaration")
     interface_decls = \
         map(lambda i:
                 self.GetInterfaceClassDeclaration(i, template, " = 0"),
             self.module.interfaces)
     return '\n'.join(interface_decls)
 
   def GetInterfaceProxyDeclarations(self):
@@ skipping 149 matching lines @@
       self.module.structs);
     self.WriteTemplateToFile("module_internal.h",
         HEADER_GUARD = self.GetHeaderGuard(self.module.name + "_INTERNAL"),
         HEADER = self.GetHeaderFile(self.module.name),
         TRAITS = '\n'.join(traits))
 
   def GenerateFiles(self):
     self.GenerateModuleHeader()
     self.GenerateModuleInternalHeader()
     self.GenerateModuleSource()