Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: Source/platform/PlatformKeyboardEvent.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Access DOM Code value using embedder API Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/PlatformKeyboardEvent.h
diff --git a/Source/platform/PlatformKeyboardEvent.h b/Source/platform/PlatformKeyboardEvent.h
index a67cc216c84893b9f4c62c5612f8b686a0ea1c10..16e629094fa12750eb0a7104d7b533f240254571 100644
--- a/Source/platform/PlatformKeyboardEvent.h
+++ b/Source/platform/PlatformKeyboardEvent.h
@@ -51,6 +51,7 @@ public:
, m_text(text)
, m_unmodifiedText(unmodifiedText)
, m_keyIdentifier(keyIdentifier)
+ , m_code("")
Wez 2014/11/20 22:17:33 Why are you not adding |code| to the constructor s
Habib Virji 2014/11/24 15:12:22 Since the constructor is used by inspector, there
, m_windowsVirtualKeyCode(windowsVirtualKeyCode)
, m_nativeVirtualKeyCode(nativeVirtualKeyCode)
, m_autoRepeat(isAutoRepeat)
@@ -76,6 +77,8 @@ public:
String keyIdentifier() const { return m_keyIdentifier; }
+ String code() const { return m_code; }
+
// Most compatible Windows virtual key code associated with the event.
// Zero for Char events.
int windowsVirtualKeyCode() const { return m_windowsVirtualKeyCode; }
@@ -93,6 +96,7 @@ protected:
String m_text;
String m_unmodifiedText;
String m_keyIdentifier;
+ String m_code;
int m_windowsVirtualKeyCode;
int m_nativeVirtualKeyCode;
bool m_autoRepeat;

Powered by Google App Engine
This is Rietveld 408576698