Source/web/WebInputEventConversion.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebInputEventConversion.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use native code instead of usb code mapping. Also updated to match firefox values. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebInputEventConversion.cpp

diff --git a/Source/web/WebInputEventConversion.cpp b/Source/web/WebInputEventConversion.cpp

index 8aa3c3d96ded7a1194156c7b87ae30c0ec57313e..83a5ed9dbf4a2cb265852695fab3b977c2e5cfee 100644

--- a/Source/web/WebInputEventConversion.cpp

+++ b/Source/web/WebInputEventConversion.cpp

@@ -682,6 +682,7 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)

if (!event.keyEvent())

return;

nativeKeyCode = event.keyEvent()->nativeVirtualKeyCode();

Wez 2014/10/25 00:23:02 Why the extra blank line?

Habib Virji 2014/10/27 16:48:36 Acknowledged.

unsigned numberOfCharacters = std::min(event.keyEvent()->text().length(), static_cast<unsigned>(textLengthCap));

for (unsigned i = 0; i < numberOfCharacters; ++i) {

text[i] = event.keyEvent()->text()[i];

« Source/core/events/KeyboardEvent.cpp ('K') | « Source/core/events/KeyboardEvent.idl ('k') | no next file » | no next file with comments »