Source/devtools/front_end/screencast/ScreencastView.js - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/screencast/ScreencastView.js

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added keyboardTest failure for virtual/slimmingpaint Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/screencast/ScreencastView.js

diff --git a/Source/devtools/front_end/screencast/ScreencastView.js b/Source/devtools/front_end/screencast/ScreencastView.js

index ec602a87d56827ebbf60eca277426c9a326ee24a..b39247fd853d5a35d95ff76be25e4abbcc96d3bb 100644

--- a/Source/devtools/front_end/screencast/ScreencastView.js

+++ b/Source/devtools/front_end/screencast/ScreencastView.js

@@ -280,7 +280,7 @@ WebInspector.ScreencastView.prototype = {

var text = event.type === "keypress" ? String.fromCharCode(event.charCode) : undefined;

this._target.inputAgent().dispatchKeyEvent(type, this._modifiersForEvent(event), event.timeStamp / 1000, text, text ? text.toLowerCase() : undefined,

- event.keyIdentifier, event.keyCode /* windowsVirtualKeyCode */, event.keyCode /* nativeVirtualKeyCode */, false, false, false);

+ event.keyIdentifier, event.code, event.keyCode /* windowsVirtualKeyCode */, event.keyCode /* nativeVirtualKeyCode */, false, false, false);

event.consume();

this._canvasElement.focus();

« no previous file with comments | « Source/core/inspector/InspectorInputAgent.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »