Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: Source/core/events/KeyboardEvent.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added keyboardTest failure for virtual/slimmingpaint Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/keyboardevent-code-expected.txt ('k') | Source/core/events/KeyboardEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/KeyboardEvent.h
diff --git a/Source/core/events/KeyboardEvent.h b/Source/core/events/KeyboardEvent.h
index 072a70408fcdfd0183dcb6f39b6d9325210a1a45..40af0e2a871ef16f8b7d37b861d5674af41d9e63 100644
--- a/Source/core/events/KeyboardEvent.h
+++ b/Source/core/events/KeyboardEvent.h
@@ -59,10 +59,10 @@ public:
}
static PassRefPtrWillBeRawPtr<KeyboardEvent> create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
- const String& keyIdentifier, unsigned location,
+ const String& keyIdentifier, const String& code, unsigned location,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
{
- return adoptRefWillBeNoop(new KeyboardEvent(type, canBubble, cancelable, view, keyIdentifier, location,
+ return adoptRefWillBeNoop(new KeyboardEvent(type, canBubble, cancelable, view, keyIdentifier, code, location,
ctrlKey, altKey, shiftKey, metaKey));
}
@@ -73,6 +73,8 @@ public:
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
const String& keyIdentifier() const { return m_keyIdentifier; }
+ const String& code() const { return m_code; }
+
unsigned location() const { return m_location; }
bool getModifierState(const String& keyIdentifier) const;
@@ -94,11 +96,12 @@ private:
KeyboardEvent(const PlatformKeyboardEvent&, AbstractView*);
KeyboardEvent(const AtomicString&, const KeyboardEventInit&);
KeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*,
- const String& keyIdentifier, unsigned location,
+ const String& keyIdentifier, const String& code, unsigned location,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
OwnPtr<PlatformKeyboardEvent> m_keyEvent;
String m_keyIdentifier;
+ String m_code;
unsigned m_location;
bool m_isAutoRepeat : 1;
};
« no previous file with comments | « LayoutTests/fast/events/keyboardevent-code-expected.txt ('k') | Source/core/events/KeyboardEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698