 Chromium Code Reviews
 Chromium Code Reviews Issue 663523002:
  Adding support for DOM3 KeyboardEvents Code in KeyboardEvents  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 663523002:
  Adding support for DOM3 KeyboardEvents Code in KeyboardEvents  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/events/KeyboardEvent.cpp | 
| diff --git a/Source/core/events/KeyboardEvent.cpp b/Source/core/events/KeyboardEvent.cpp | 
| index 8ddcf6b10b68eb2b80d8232c63322fa0a3c04f89..97a86decf98d12dbaca801aaf725bdabcf756d36 100644 | 
| --- a/Source/core/events/KeyboardEvent.cpp | 
| +++ b/Source/core/events/KeyboardEvent.cpp | 
| @@ -106,6 +106,7 @@ KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* vie | 
| true, true, view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey()) | 
| , m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key))) | 
| , m_keyIdentifier(key.keyIdentifier()) | 
| + , m_code(key.code()) | 
| , m_location(keyLocationCode(key)) | 
| , m_isAutoRepeat(key.isAutoRepeat()) | 
| { | 
| @@ -121,10 +122,10 @@ KeyboardEvent::KeyboardEvent(const AtomicString& eventType, const KeyboardEventI | 
| } | 
| KeyboardEvent::KeyboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView *view, | 
| - const String &keyIdentifier, unsigned location, | 
| - bool ctrlKey, bool altKey, bool shiftKey, bool metaKey) | 
| + const String& keyIdentifier, const String& code, unsigned location, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey) | 
| 
Mike West
2015/01/29 11:49:34
Nit: Why reformat this?
 
Habib Virji
2015/01/29 12:24:14
Since it was more than 4 spaces, pre-submit was gi
 | 
| : UIEventWithKeyState(eventType, canBubble, cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey) | 
| , m_keyIdentifier(keyIdentifier) | 
| + , m_code(code) | 
| , m_location(location) | 
| , m_isAutoRepeat(false) | 
| { | 
| @@ -135,8 +136,7 @@ KeyboardEvent::~KeyboardEvent() | 
| } | 
| void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view, | 
| - const String &keyIdentifier, unsigned location, | 
| - bool ctrlKey, bool altKey, bool shiftKey, bool metaKey) | 
| + const String& keyIdentifier, unsigned location, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey) | 
| 
Mike West
2015/01/29 11:49:34
Nit: Why reformat this?
 
Habib Virji
2015/01/29 12:24:14
Since it was more than 4 spaces, pre-submit was gi
 | 
| { | 
| if (dispatched()) | 
| return; |