Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: Source/core/events/KeyboardEvent.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated to use domCode instead of native domCode Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/KeyboardEvent.cpp
diff --git a/Source/core/events/KeyboardEvent.cpp b/Source/core/events/KeyboardEvent.cpp
index 8ddcf6b10b68eb2b80d8232c63322fa0a3c04f89..cd534d2f9f6bce7b3386ec9146be9054b3ff5053 100644
--- a/Source/core/events/KeyboardEvent.cpp
+++ b/Source/core/events/KeyboardEvent.cpp
@@ -106,6 +106,7 @@ KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* vie
true, true, view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey())
, m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key)))
, m_keyIdentifier(key.keyIdentifier())
+ , m_code(key.code())
, m_location(keyLocationCode(key))
, m_isAutoRepeat(key.isAutoRepeat())
{
@@ -115,16 +116,17 @@ KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* vie
KeyboardEvent::KeyboardEvent(const AtomicString& eventType, const KeyboardEventInit& initializer)
: UIEventWithKeyState(eventType, initializer.bubbles, initializer.cancelable, initializer.view, initializer.detail, initializer.ctrlKey, initializer.altKey, initializer.shiftKey, initializer.metaKey)
, m_keyIdentifier(initializer.keyIdentifier)
+ , m_code(initializer.code)
, m_location(initializer.location)
, m_isAutoRepeat(initializer.repeat)
{
}
KeyboardEvent::KeyboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView *view,
- const String &keyIdentifier, unsigned location,
- bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
+ const String &keyIdentifier, const String &code, unsigned location, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
: UIEventWithKeyState(eventType, canBubble, cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey)
, m_keyIdentifier(keyIdentifier)
+ , m_code(code)
, m_location(location)
, m_isAutoRepeat(false)
{
@@ -135,8 +137,7 @@ KeyboardEvent::~KeyboardEvent()
}
void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
- const String &keyIdentifier, unsigned location,
- bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
+ const String &keyIdentifier, const String &code, unsigned location, bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
{
if (dispatched())
return;
@@ -144,6 +145,7 @@ void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble,
initUIEvent(type, canBubble, cancelable, view, 0);
m_keyIdentifier = keyIdentifier;
+ m_code = code;
m_location = location;
m_ctrlKey = ctrlKey;
m_shiftKey = shiftKey;

Powered by Google App Engine
This is Rietveld 408576698