Source/web/WebViewImpl.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 12e302b8b53867edea66e1acfffc8f5c8f56f128..7df630267a41a555e94ebaeb5165377f3cadf9ba 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -1001,6 +1001,7 @@ bool WebViewImpl::handleKeyEvent(const WebKeyboardEvent& event)

LocalFrame* frame = toLocalFrame(focusedFrame.get());

PlatformKeyboardEventBuilder evt(event);

+ evt.setKeyboardEventDOMCodeValue(m_client->keyboardDOMCodeValue(evt.nativeVirtualKeyCode()));

kpschoedel 2014/12/02 17:00:52 This uses WebKeyboardEvent.nativeKeyCode, which co

if (frame->eventHandler().keyEvent(evt)) {

if (WebInputEvent::RawKeyDown == event.type) {

« Source/core/events/KeyboardEvent.h ('K') | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »