Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/WebInputEventConversion.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 336 matching lines @@
 
     if (type == RawKeyDown) {
         m_text = String();
         m_unmodifiedText = String();
     } else {
         m_keyIdentifier = String();
         m_windowsVirtualKeyCode = 0;
     }
 }
 
+void PlatformKeyboardEventBuilder::setDOMCode(const char* code)

[Wez, 2014/12/02 04:23:30]

Could we add the code member to WebKeyboardEvent and remove the setDOMCode()
setter here?

[Habib Virji, 2014/12/02 11:52:20]

I was trying to avoid, as that will increase the size of the WebKeyboardEvent
struct size.

+{
+    m_code = String(code);
+}
+
 // Please refer to bug http://b/issue?id=961192, which talks about Webkit
 // keyboard event handling changes. It also mentions the list of keys
 // which don't have associated character events.
 bool PlatformKeyboardEventBuilder::isCharacterKey() const
 {
     switch (windowsVirtualKeyCode()) {
     case VKEY_BACK:
     case VKEY_ESCAPE:
         return false;
     }
@@ skipping 308 matching lines @@
         modifiers |= WebInputEvent::IsRight;
 
     timeStampSeconds = event.timeStamp() / millisPerSecond;
     windowsKeyCode = event.keyCode();
 
     // The platform keyevent does not exist if the event was created using
     // initKeyboardEvent.
     if (!event.keyEvent())
         return;
     nativeKeyCode = event.keyEvent()->nativeVirtualKeyCode();
+
     unsigned numberOfCharacters = std::min(event.keyEvent()->text().length(), static_cast<unsigned>(textLengthCap));
     for (unsigned i = 0; i < numberOfCharacters; ++i) {
         text[i] = event.keyEvent()->text()[i];
         unmodifiedText[i] = event.keyEvent()->unmodifiedText()[i];
     }
     memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), event.keyIdentifier().length());
 }
 
 WebInputEvent::Type toWebKeyboardEventType(PlatformEvent::Type type)
 {
@@ skipping 131 matching lines @@
     modifiers = getWebInputModifiers(event);
 
     globalX = event.screenX();
     globalY = event.screenY();
     IntPoint localPoint = convertAbsoluteLocationForRenderObject(event.absoluteLocation(), *renderObject);
     x = localPoint.x();
     y = localPoint.y();
 }
 
 } // namespace blink