Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/core/events/KeyboardEvent.cpp

 /**
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/events/KeyboardEvent.h"
 
+#include "KeyboardCode.h"

[Wez, 2014/11/20 22:17:33]

What is this include required for?

[Habib Virji, 2014/11/24 15:12:22]

Done. It was previous include file that i created, include was left by mistake.

 #include "platform/PlatformKeyboardEvent.h"
 #include "platform/WindowsKeyboardCodes.h"
 
 namespace blink {
 
 static inline const AtomicString& eventTypeForKeyboardEventType(PlatformEvent::Type type)
 {
     switch (type) {
         case PlatformEvent::KeyUp:
             return EventTypeNames::keyup;
@@ skipping 65 matching lines @@
 {
 }
 
 KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* view)
     : UIEventWithKeyState(eventTypeForKeyboardEventType(key.type()),
                           true, true, view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey())
     , m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key)))
     , m_keyIdentifier(key.keyIdentifier())
     , m_location(keyLocationCode(key))
     , m_isAutoRepeat(key.isAutoRepeat())
+    , m_code(key.code())
 {
 }
 
 KeyboardEvent::KeyboardEvent(const AtomicString& eventType, const KeyboardEventInit& initializer)
     : UIEventWithKeyState(eventType, initializer.bubbles, initializer.cancelable, initializer.view, initializer.detail, initializer.ctrlKey, initializer.altKey, initializer.shiftKey, initializer.metaKey)
     , m_keyIdentifier(initializer.keyIdentifier)
     , m_location(initializer.location)
     , m_isAutoRepeat(initializer.repeat)
+    , m_code(initializer.code)
 {
 }
 
 KeyboardEvent::KeyboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView *view,
                              const String &keyIdentifier,  unsigned location,
                              bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
     : UIEventWithKeyState(eventType, canBubble, cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey)
     , m_keyIdentifier(keyIdentifier)
     , m_location(location)
     , m_isAutoRepeat(false)
 {
 }
 
 KeyboardEvent::~KeyboardEvent()
 {
 }
 
 void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,

[Wez, 2014/11/20 22:17:33]

Looks like this and the constructor above also need updating to take a |code|?

[Habib Virji, 2014/11/24 15:12:21]

Done. Have added in above constructor and updated init function. Previously
omitted as above constructor is used in test functions and did not knew if code
will be useful for them. Have updated code now to include code. 

                                       const String &keyIdentifier, unsigned location,
                                       bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
 {
     if (dispatched())
         return;
 
     initUIEvent(type, canBubble, cancelable, view, 0);
 
     m_keyIdentifier = keyIdentifier;
     m_location = location;
@@ skipping 75 matching lines @@
 {
 }
 
 bool KeyboardEventDispatchMediator::dispatchEvent(EventDispatcher* dispatcher) const
 {
     // Make sure not to return true if we already took default action while handling the event.
     return EventDispatchMediator::dispatchEvent(dispatcher) && !event()->defaultHandled();
 }
 
 } // namespace blink