Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/core/events/KeyboardEvent.cpp

 /**
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/events/KeyboardEvent.h"
 
+#include "KeyboardCode.h"
 #include "platform/PlatformKeyboardEvent.h"
 #include "platform/WindowsKeyboardCodes.h"
 
 namespace blink {
 
 static inline const AtomicString& eventTypeForKeyboardEventType(PlatformEvent::Type type)
 {
     switch (type) {
         case PlatformEvent::KeyUp:
             return EventTypeNames::keyup;
@@ skipping 42 matching lines @@
     case VK_RCONTROL:
     case VK_RSHIFT:
     case VK_RMENU:
     case VK_RWIN:
         return KeyboardEvent::DOM_KEY_LOCATION_RIGHT;
     default:
         return KeyboardEvent::DOM_KEY_LOCATION_STANDARD;
     }
 }
 
+static inline String nativeCodeToKeyCode(PlatformEvent::Type type, int nativeCode)

[Wez, 2014/10/25 00:23:02]

This takes a nativeKeyCode and returns a DOM |code| string, not a |keyCode|
value - perhaps name it nativeCodeToDomCode

+{
+    String code = "";
+
+    if (type == PlatformEvent::Char)
+        return code;

[Wez, 2014/10/25 00:23:02]

Why would you ever call this for a Char event?

[Habib Virji, 2014/10/27 16:48:36]

It is due to KeyboardEvent constructor getting called for a char event. This
function is not needed any more.

+
+    for (unsigned long i = 0; i < (sizeof(keyCodeMap)/ sizeof(keyCodeMap[0])); ++i) {
+        if (nativeCode && nativeCode == keyCodeMap[i].nativeCode) {
+            code = String(keyCodeMap[i].code);
+            return code;

[Wez, 2014/10/25 00:23:02]

Why not return the new String directly?

[Habib Virji, 2014/10/27 16:48:36]

Acknowledged.

+        }
+    }
+
+    return code;

[Wez, 2014/10/25 00:23:02]

If you reach here then code is always "" - why do you need a local variable as
well (and above).

[Habib Virji, 2014/10/27 16:48:36]

Acknowledged.

+}
+
 KeyboardEventInit::KeyboardEventInit()
     : location(0)
     , ctrlKey(false)
     , altKey(false)
     , shiftKey(false)
     , metaKey(false)
     , repeat(false)
 {
 }
 
 KeyboardEvent::KeyboardEvent()
     : m_location(DOM_KEY_LOCATION_STANDARD)
     , m_isAutoRepeat(false)
 {
 }
 
 KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent& key, AbstractView* view)
     : UIEventWithKeyState(eventTypeForKeyboardEventType(key.type()),
                           true, true, view, 0, key.ctrlKey(), key.altKey(), key.shiftKey(), key.metaKey())
     , m_keyEvent(adoptPtr(new PlatformKeyboardEvent(key)))
     , m_keyIdentifier(key.keyIdentifier())
     , m_location(keyLocationCode(key))
     , m_isAutoRepeat(key.isAutoRepeat())
+    , m_code(nativeCodeToKeyCode(key.type(), key.nativeVirtualKeyCode()))
 {
 }
 
 KeyboardEvent::KeyboardEvent(const AtomicString& eventType, const KeyboardEventInit& initializer)
     : UIEventWithKeyState(eventType, initializer.bubbles, initializer.cancelable, initializer.view, initializer.detail, initializer.ctrlKey, initializer.altKey, initializer.shiftKey, initializer.metaKey)
     , m_keyIdentifier(initializer.keyIdentifier)
     , m_location(initializer.location)
     , m_isAutoRepeat(initializer.repeat)
+    , m_code(initializer.code)
 {
 }
 
 KeyboardEvent::KeyboardEvent(const AtomicString& eventType, bool canBubble, bool cancelable, AbstractView *view,
                              const String &keyIdentifier,  unsigned location,
                              bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
     : UIEventWithKeyState(eventType, canBubble, cancelable, view, 0, ctrlKey, altKey, shiftKey, metaKey)
     , m_keyIdentifier(keyIdentifier)
     , m_location(location)
     , m_isAutoRepeat(false)
@@ skipping 93 matching lines @@
 {
 }
 
 bool KeyboardEventDispatchMediator::dispatchEvent(EventDispatcher* dispatcher) const
 {
     // Make sure not to return true if we already took default action while handling the event.
     return EventDispatchMediator::dispatchEvent(dispatcher) && !event()->defaultHandled();
 }
 
 } // namespace blink