Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 586 matching lines @@
     // Device Orientation, Device Motion, Device Light, Battery, Gamepad.
 
     // Request the platform to start listening to the events of the specified
     // type and notify the given listener (if not null) when there is an update.
     virtual void startListening(WebPlatformEventType type, WebPlatformEventListener* listener) { }
 
     // Request the platform to stop listening to the specified event and no
     // longer notify the listener, if any.
     virtual void stopListening(WebPlatformEventType type) { }
 
+    // This method converts from the supplied DOM code enum to the
+    // embedder's DOM code value for the key pressed. |domCode| values are
+    // based on the value defined in ui/events/keycodes/dom4/keycode_converter_data.h.
+    // Returns null string, if DOM code value is not found.
+    virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); }

[Mike West, 2015/01/29 11:49:35]

"DOM Code String" is ambiguous. Could you rename these to something which makes
it clear that they're key-code related?

[Habib Virji, 2015/01/29 12:24:14]

Will it be okay to rename them DOMKeyboardCodeString? 

This was suggestion which wez suggested. This was kept to keep it consistent
with chromium.

+
+    // This method converts from the suppled DOM code value to the
+    // embedder's DOM code enum for the key pressed. |codeString| is defined in
+    // ui/events/keycodes/dom4/keycode_converter_data.h.
+    // Returns 0, if DOM code enum is not found.
+    virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }

[Mike West, 2015/01/29 11:49:34]

It's a bit strange that we're calling this an enum, when it's completely opaque
to Blink. Blink has an int, and doesn't have any understanding of the enum that
lives at the platform layer.

Can the enum live at the platform layer instead?

[Habib Virji, 2015/01/29 12:24:14]

We went through that discussion
https://codereview.chromium.org/663523002/#msg43, but wez suggested to have it
in chromium side. 

[Rick Byers, 2015/01/29 21:11:10]

Yeah, I thought Wez's arguments for making it opaque to blink were convincing. 
We could call it something other than "enum" if we wanted, but chromium calls it
that so I'm happy to defer to the chromium keyboard experts (eg. Wez) for naming
consistency.

+
     // Quota -----------------------------------------------------------
 
     // Queries the storage partition's storage usage and quota information.
     // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called
     // with the current usage and quota information for the partition. When
     // an error occurs WebStorageQuotaCallbacks::didFail is called with an
     // error code.
     virtual void queryStorageUsageAndQuota(
         const WebURL& storagePartition,
         WebStorageQuotaType,
@@ skipping 30 matching lines @@
 
     virtual WebNavigatorConnectProvider* navigatorConnectProvider() { return 0; }
 
 protected:
     virtual ~Platform() { }
 };
 
 } // namespace blink
 
 #endif