Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/tests/KeyboardTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "config.h"
 
 #include <gtest/gtest.h>
 
 #include "core/editing/EditingBehavior.h"
 #include "core/editing/Editor.h"
 #include "core/events/EventTarget.h"
 #include "core/events/KeyboardEvent.h"
+#include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
+#include "core/page/Page.h"
+#include "core/testing/URLTestHelpers.h"
 #include "platform/KeyboardCodes.h"
 #include "public/web/WebInputEvent.h"
 #include "web/WebInputEventConversion.h"
+#include "web/WebViewImpl.h"
+#include "web/tests/FrameTestHelpers.h"
 
 using namespace blink;
 
 namespace {
 
 class KeyboardTest : public testing::Test {
 public:
 
     // Pass a WebKeyboardEvent into the EditorClient and get back the string
     // name of which editing event that key causes.
     // E.g., sending in the enter key gives back "InsertNewline".
     const char* interpretKeyEvent(
         const WebKeyboardEvent& webKeyboardEvent,
         PlatformEvent::Type keyType)
     {
-        PlatformKeyboardEventBuilder evt(webKeyboardEvent);
+        const std::string baseURL("http://www.test5.com/");
+        const std::string fileName("fixed_layout.html");
+
+        URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
+        FrameTestHelpers::WebViewHelper webViewHelper;
+        WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(baseURL + fileName, true);

[Wez, 2015/01/17 02:35:10]

Doesn't this need cleaning up somewhere?

[bokan, 2015/01/20 17:05:58]

webViewHelper will clean up on destruction. That said, please move webViewHelper
to be a private member of the KeyboardTest class and move the rest of the
boilerplate (registerMockedURLFromBaseURL, initializeAndLoad, etc.) into the
individual tests cases. For example of how this should look:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Habib Virji, 2015/01/22 16:01:30]

Done.

+        int pageWidth = 640;
+        int pageHeight = 480;
+        webViewImpl->resize(WebSize(pageWidth, pageHeight));
+        webViewImpl->layout();
+
+        PlatformKeyboardEventBuilder evt(toLocalFrame(webViewImpl->page()->mainFrame())->view(), webKeyboardEvent);
         evt.setKeyType(keyType);
         RefPtrWillBeRawPtr<KeyboardEvent> keyboardEvent = KeyboardEvent::create(evt, 0);
         OwnPtr<Settings> settings = Settings::create();
         EditingBehavior behavior(settings->editingBehaviorType());
         return behavior.interpretKeyEvent(*keyboardEvent);
     }
 
     // Set up a WebKeyboardEvent KEY_DOWN event with key code and modifiers.
     void setupKeyDownEvent(WebKeyboardEvent* keyboardEvent,
                            char keyCode,
@@ skipping 137 matching lines @@
 }
 
 TEST_F(KeyboardTest, TestInsertNewline4)
 {
     int modifiers = WebInputEvent::AltKey | WebInputEvent::ShiftKey;
     const char* result = interpretNewLine(modifiers);
     EXPECT_STREQ("InsertNewline", result);
 }
 
 } // empty namespace