Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 945 matching lines @@
         webFrame->client()->forwardInputEvent(&event);
         return true;
     }
 
     if (!focusedFrame || !focusedFrame->isLocalFrame())
         return false;
 
     LocalFrame* frame = toLocalFrame(focusedFrame.get());
 
     PlatformKeyboardEventBuilder evt(event);
+    evt.setKeyboardEventDOMCodeValue(m_client->keyboardDOMCodeValue(evt.domCode()));

[Wez, 2015/01/08 01:14:48]

It reads very oddly to be passing evt.domCode() into the conversion routine;
really what you're passing is the event.domCode value, I think.

Do we need to do the conversion from numeric value to code here, or could we
defer it until we need to convert from PlatformKeyboardEvent to DOM
KeyboardEvent?

[Habib Virji, 2015/01/12 15:34:17]

I have deferred it, please have a look. It now happens in
WebInputEventConversion.

[Wez, 2015/01/17 02:35:10]

SGTM - please check w/ e.g. rbyers@ that the frameView() references throughout
this patch are correct - I'm not sure whether mainFrameImpl() can always be
relied upon.

 
     if (frame->eventHandler().keyEvent(evt)) {
         if (WebInputEvent::RawKeyDown == event.type) {
             // Suppress the next keypress event unless the focused node is a plug-in node.
             // (Flash needs these keypress events to handle non-US keyboards.)
             Element* element = focusedElement();
             if (!element || !element->renderer() || !element->renderer()->isEmbeddedObject())
                 m_suppressNextKeypressEvent = true;
         }
         return true;
@@ skipping 3526 matching lines @@
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 void WebViewImpl::forceNextWebGLContextCreationToFail()
 {
     WebGLRenderingContext::forceNextWebGLContextCreationToFail();
 }
 
 } // namespace blink