Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/WebInputEventConversion.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 295 matching lines @@
 }
 
 PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder(const WebKeyboardEvent& e)
 {
     m_type = toPlatformKeyboardEventType(e.type);
     m_text = String(e.text);
     m_unmodifiedText = String(e.unmodifiedText);
     m_keyIdentifier = String(e.keyIdentifier);
     m_autoRepeat = (e.modifiers & WebInputEvent::IsAutoRepeat);
     m_nativeVirtualKeyCode = e.nativeKeyCode;
+    m_domCode = e.domCode;

[Wez, 2015/01/08 01:14:48]

Is there any point in storing the numeric form of this value? It's opaque (i.e.
meaningless) to Blink, and you're going to use it to det the m_code string in
the WebViewImpl later on anyway.

[Habib Virji, 2015/01/12 15:34:17]

The only reason I was saving this is, as I did not found a way of using embedder
API to fetch domCode value for WebKeyboardEvent, as there is no access to the
instance of the WebViewClient.

In new patch I have modified this now, and does not require storing domCode. 

     m_isKeypad = (e.modifiers & WebInputEvent::IsKeyPad);
     m_isSystemKey = e.isSystemKey;
 
     m_modifiers = toPlatformEventModifiers(e.modifiers);
 
     // FIXME: PlatformKeyboardEvents expect a locational version of the keycode (e.g. VK_LSHIFT
     // instead of VK_SHIFT). This should be changed so the location/keycode are stored separately,
     // as in other places in the code.
     m_windowsVirtualKeyCode = e.windowsKeyCode;
     if (e.windowsKeyCode == VK_SHIFT) {
@@ skipping 26 matching lines @@
 
     if (type == RawKeyDown) {
         m_text = String();
         m_unmodifiedText = String();
     } else {
         m_keyIdentifier = String();
         m_windowsVirtualKeyCode = 0;
     }
 }
 
+void PlatformKeyboardEventBuilder::setKeyboardEventDOMCodeValue(const char* code)
+{
+    m_code = String(code);
+}

[Habib Virji, 2015/01/12 15:34:17]

This code is now removed.

+
 // Please refer to bug http://b/issue?id=961192, which talks about Webkit
 // keyboard event handling changes. It also mentions the list of keys
 // which don't have associated character events.
 bool PlatformKeyboardEventBuilder::isCharacterKey() const
 {
     switch (windowsVirtualKeyCode()) {
     case VKEY_BACK:
     case VKEY_ESCAPE:
         return false;
     }
@@ skipping 293 matching lines @@
         modifiers |= WebInputEvent::IsRight;
 
     timeStampSeconds = event.timeStamp() / millisPerSecond;
     windowsKeyCode = event.keyCode();
 
     // The platform keyevent does not exist if the event was created using
     // initKeyboardEvent.
     if (!event.keyEvent())
         return;
     nativeKeyCode = event.keyEvent()->nativeVirtualKeyCode();
+    domCode = event.keyEvent()->domCode();

[Wez, 2015/01/08 01:14:48]

Similarly to above, can we arrange this translation via the embedder API, from
string back to number, rather than passing the numeric value around in
[Platform]KeyboardEvent as well as the string value?

[Habib Virji, 2015/01/12 15:34:17]

New code has embedder API for this purpose.

     unsigned numberOfCharacters = std::min(event.keyEvent()->text().length(), static_cast<unsigned>(textLengthCap));
     for (unsigned i = 0; i < numberOfCharacters; ++i) {
         text[i] = event.keyEvent()->text()[i];
         unmodifiedText[i] = event.keyEvent()->unmodifiedText()[i];
     }
     memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), event.keyIdentifier().length());
 }
 
 WebInputEvent::Type toWebKeyboardEventType(PlatformEvent::Type type)
 {
@@ skipping 14 matching lines @@
 WebKeyboardEventBuilder::WebKeyboardEventBuilder(const PlatformKeyboardEvent& event)
 {
     type = toWebKeyboardEventType(event.type());
     modifiers = toWebEventModifiers(event.modifiers());
     if (event.isAutoRepeat())
         modifiers |= WebInputEvent::IsAutoRepeat;
     if (event.isKeypad())
         modifiers |= WebInputEvent::IsKeyPad;
     isSystemKey = event.isSystemKey();
     nativeKeyCode = event.nativeVirtualKeyCode();
+    domCode = event.domCode();
 
     windowsKeyCode = windowsKeyCodeWithoutLocation(event.windowsVirtualKeyCode());
     modifiers |= locationModifiersFromWindowsKeyCode(event.windowsVirtualKeyCode());
 
     event.text().copyTo(text, 0, textLengthCap);
     event.unmodifiedText().copyTo(unmodifiedText, 0, textLengthCap);
     memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), std::min(static_cast<unsigned>(keyIdentifierLengthCap), event.keyIdentifier().length()));
 }
 
 static WebTouchPoint toWebTouchPoint(const Touch* touch, const RenderObject* renderObject, WebTouchPoint::State state)
@@ skipping 83 matching lines @@
     modifiers = getWebInputModifiers(event);
 
     globalX = event.screenX();
     globalY = event.screenY();
     IntPoint localPoint = convertAbsoluteLocationForRenderObject(event.absoluteLocation(), *renderObject);
     x = localPoint.x();
     y = localPoint.y();
 }
 
 } // namespace blink