Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/core/events/KeyboardEvent.h

 /*
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 18 matching lines @@
 
 namespace blink {
 
 class EventDispatcher;
 class PlatformKeyboardEvent;
 
 struct KeyboardEventInit : public UIEventInit {
     KeyboardEventInit();
 
     String keyIdentifier;
+    String code;
     unsigned location;
     bool ctrlKey;
     bool altKey;
     bool shiftKey;
     bool metaKey;
     bool repeat;
 };
 
 class KeyboardEvent final : public UIEventWithKeyState {
     DEFINE_WRAPPERTYPEINFO();
@@ skipping 14 matching lines @@
     {
         return adoptRefWillBeNoop(new KeyboardEvent(platformEvent, view));
     }
 
     static PassRefPtrWillBeRawPtr<KeyboardEvent> create(const AtomicString& type, const KeyboardEventInit& initializer)
     {
         return adoptRefWillBeNoop(new KeyboardEvent(type, initializer));
     }
 
     static PassRefPtrWillBeRawPtr<KeyboardEvent> create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
-        const String& keyIdentifier, unsigned location,
+        const String& keyIdentifier, const String& code, unsigned location,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)
     {
-        return adoptRefWillBeNoop(new KeyboardEvent(type, canBubble, cancelable, view, keyIdentifier, location,
+        return adoptRefWillBeNoop(new KeyboardEvent(type, canBubble, cancelable, view, keyIdentifier, code, location,
         ctrlKey, altKey, shiftKey, metaKey));
     }
 
     virtual ~KeyboardEvent();
 
     void initKeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*,
-        const String& keyIdentifier, unsigned location,
+        const String& keyIdentifier, const String& code, unsigned location,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
 
     const String& keyIdentifier() const { return m_keyIdentifier; }
+    const String& code() { return m_code; };
+
     unsigned location() const { return m_location; }
 
     bool getModifierState(const String& keyIdentifier) const;
 
     const PlatformKeyboardEvent* keyEvent() const { return m_keyEvent.get(); }
 
     virtual int keyCode() const override; // key code for keydown and keyup, character for keypress
     virtual int charCode() const override; // character code for keypress, 0 for keydown and keyup
     bool repeat() const { return m_isAutoRepeat; }
 
     virtual const AtomicString& interfaceName() const override;
     virtual bool isKeyboardEvent() const override;
     virtual int which() const override;
 
     virtual void trace(Visitor*) override;
 
 private:
     KeyboardEvent();
     KeyboardEvent(const PlatformKeyboardEvent&, AbstractView*);
     KeyboardEvent(const AtomicString&, const KeyboardEventInit&);
     KeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*,
-        const String& keyIdentifier, unsigned location,
+        const String& keyIdentifier, const String& code, unsigned location,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
 
     OwnPtr<PlatformKeyboardEvent> m_keyEvent;
     String m_keyIdentifier;
+    String m_code;

[garykac, 2014/12/02 16:29:32]

While we need to expose the |code| string as part of the public API, can we use
|code| enums internally so that we're not copying strings all over the place?

These enums for |code| were just recently added:
https://codereview.chromium.org/641753003

[Habib Virji, 2014/12/02 16:39:05]

The only reason for not passing int value was it will need table again on the
blink side, to convert enum value to the string. Is it okay to have a table for
a conversion purpose?

     unsigned m_location;
     bool m_isAutoRepeat : 1;
 };
 
 class KeyboardEventDispatchMediator : public EventDispatchMediator {
 public:
     static PassRefPtrWillBeRawPtr<KeyboardEventDispatchMediator> create(PassRefPtrWillBeRawPtr<KeyboardEvent>);
 private:
     explicit KeyboardEventDispatchMediator(PassRefPtrWillBeRawPtr<KeyboardEvent>);
     virtual bool dispatchEvent(EventDispatcher*) const override;
 };
 
 DEFINE_EVENT_TYPE_CASTS(KeyboardEvent);
 
 } // namespace blink
 
 #endif // KeyboardEvent_h