Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7165)

Unified Diff: chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js

Issue 663513003: Add an unittest for background/volume_manager.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js
diff --git a/chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js b/chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js
index 58c4e23db0c1c2f64089cdb10571510dd81959ff..9a46e5bfd2c2ed28d7bb0182e11eab3c3e40756d 100644
--- a/chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js
+++ b/chrome/test/data/file_manager/unit_tests/mocks/mock_file_system.js
@@ -8,6 +8,6 @@
* @constructor
*/
function MockFileSystem(volumeId) {
hirono 2014/10/24 07:12:22 Could you reuse TestFileSystem? https://code.goog
yawano 2014/10/27 00:25:08 While they are very similar, IMHO, they should be
hirono 2014/10/27 02:15:27 Actually I added TestFileSystem class for testing
- this.name = '';
- this.root = new MockFileEntry(volumeId, '/');
+ this.name = volumeId;
+ this.root = new MockDirectoryEntry(this, '/');
}

Powered by Google App Engine
This is Rietveld 408576698