Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: build_tools/build_utils.py

Issue 6635045: Updates to make install_third_party build gtest and gmock on windows. Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_tools/generate_windows_installer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_tools/build_utils.py
===================================================================
--- build_tools/build_utils.py (revision 760)
+++ build_tools/build_utils.py (working copy)
@@ -79,11 +79,9 @@
# a fully-qualified absolute path, on Windows it must include the drive letter.
# |shell_env| describes the environment used by any subprocess (this is
# normally obtained from GetShellEnvironment()
-# TODO(dspringer,khim): make this work properly for hermetic cygwin (see bug
-# http://code.google.com/p/nativeclient/issues/detail?id=1122)
def HermeticBuildPath(abs_path, shell_env):
if (sys.platform == 'win32'):
- return abs_path
+ return abs_path.replace('\\', '\\\\')
return abs_path
« no previous file with comments | « no previous file | build_tools/generate_windows_installer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698