[ServiceWorkerCacheStorage] Delete unused get/create functions.

[ServiceWorkerCacheStorage] Delete unused get/create functions.

The spec added 'open' and removed 'get/create'.  Delete get and create.

CLs in this three-legged-patch:

1. Add open to browser - https://codereview.chromium.org/664433003/
2. Add open (remove get/create) to Blink - https://codereview.chromium.org/638023003
*3. Remove get/create from browser - https://codereview.chromium.org/663503002/

BUG=423942
Committed: https://crrev.com/4650dfdfc1407b59ad759d56d62565588f08bfe7
Cr-Commit-Position: refs/heads/master@{#300266}

[jkarlin, 2014-10-16 15:34:26]

jkarlin@chromium.org changed reviewers:
+ falken@chromium.org, michaeln@chromium.org, tsepez@chromium.org

[jkarlin, 2014-10-16 15:34:26]

falken@chromium.org: Please review changes in all

michaeln@chromium.org: Please review changes in all

tsepez@chromium.org: Please review changes in service_worker_message.h

Thanks!

[Tom Sepez, 2014-10-16 16:35:55]

Rubberstamp LGTM on deleting messages.

[jsbell, 2014-10-16 20:41:47]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2014-10-16 20:41:48]

A few drive-by test nits, otherwise lgtm (but I'm not in OWNERS)

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
File
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:256:
EXPECT_TRUE(Open(origin2_, "foo"));
Should add assertion that cache pointers differ. Previously, the second Open()
would fail if the two origins were confused, but that wouldn't be detected now.

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:323:
EXPECT_TRUE(Open(origin1_, "你好"));
Is re-opening here actually useful to the test?

(not new in this CL, but more obvious)

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:333:
EXPECT_TRUE(Open(origin1_, ""));
Ditto?

[michaeln, 2014-10-17 02:03:50]

lgtm!

[falken, 2014-10-17 02:06:52]

lgtm

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
File
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:251:
EXPECT_TRUE(cache.get() != callback_cache_.get());
Not new in this CL, but why not use EXPECT_NE(cache, callback_cache_.get())?
(and throughout this file, there's places where EXPECT_EQ/NE could be used)

[jkarlin, 2014-10-17 15:31:43]

Thanks everyone!

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
File
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:251:
EXPECT_TRUE(cache.get() != callback_cache_.get());
On 2014/10/17 02:06:52, falken wrote:
> Not new in this CL, but why not use EXPECT_NE(cache, callback_cache_.get())?
> (and throughout this file, there's places where EXPECT_EQ/NE could be used)

Done. Fixed the others as well.

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:256:
EXPECT_TRUE(Open(origin2_, "foo"));
On 2014/10/16 20:41:48, jsbell wrote:
> Should add assertion that cache pointers differ. Previously, the second Open()
> would fail if the two origins were confused, but that wouldn't be detected
now.

Done.

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:323:
EXPECT_TRUE(Open(origin1_, "你好"));
On 2014/10/16 20:41:48, jsbell wrote:
> Is re-opening here actually useful to the test?
> 
> (not new in this CL, but more obvious)

It tests the second codepath (opening an existing cache) with the character set.

https://codereview.chromium.org/663503002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:333:
EXPECT_TRUE(Open(origin1_, ""));
On 2014/10/16 20:41:48, jsbell wrote:
> Ditto?

Ditto.  We want to test both code paths for empty key support.

[jkarlin, 2014-10-18 23:30:26]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-10-18 23:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663503002/80001

[commit-bot: I haz the power, 2014-10-18 23:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-18 23:34:13]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/70436)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jkarlin, 2014-10-20 14:23:57]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-10-20 14:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663503002/100001

[commit-bot: I haz the power, 2014-10-20 14:38:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-20 14:39:41]

Patchset 6 (id:??) landed as
https://crrev.com/4650dfdfc1407b59ad759d56d62565588f08bfe7
Cr-Commit-Position: refs/heads/master@{#300266}