Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: sky/engine/core/BUILD.gn

Issue 663483006: Fix sky to pass 'gn check' (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Moar redundant Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/BUILD.gn
diff --git a/sky/engine/core/BUILD.gn b/sky/engine/core/BUILD.gn
index 06a80bf52ec5251cc7326bd228b0da3a3e10159c..39d2daf13ea77e8e68276aec78113abd799410b9 100644
--- a/sky/engine/core/BUILD.gn
+++ b/sky/engine/core/BUILD.gn
@@ -11,7 +11,7 @@ visibility = ["//sky/engine/*"]
rel_sky_core_gen_dir = rebase_path(sky_core_output_dir, root_build_dir)
source_set("libraries") {
- deps = [
+ public_deps = [
jamesr 2014/10/24 21:42:47 i assume you're gonna tighten this up at some poin
"//base:base",
"//gin",
"//gpu/command_buffer/client:gles2_c_lib",
@@ -20,6 +20,7 @@ source_set("libraries") {
"//mojo/public/c/system:for_shared_library",
"//mojo/public/cpp/bindings",
"//mojo/public/cpp/utility",
+ "//mojo/public/cpp/system",
"//skia",
"//sky/engine/wtf",
"//third_party/angle:translator",
@@ -31,8 +32,6 @@ source_set("libraries") {
"//url",
"//v8",
]
-
- forward_dependent_configs_from = deps
}
source_set("prerequisites") {

Powered by Google App Engine
This is Rietveld 408576698