Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 663483006: Fix sky to pass 'gn check' (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | sky/engine/core/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index e54ab0fbc1d8132a77ebf053b1f0407c5ba39e8b..8cf23e1c04a82ccaa1f63e87ca1f969c7894de01 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -136,14 +136,16 @@ template("mojom") {
sources = process_file_template(invoker.sources, generator_cpp_outputs)
data = process_file_template(invoker.sources, generator_js_outputs)
deps = [
- ":$generator_target_name",
"//mojo/public/cpp/bindings",
]
if (defined(invoker.deps)) {
deps += invoker.deps
}
+ public_deps = [
+ ":$generator_target_name",
+ ]
if (defined(invoker.public_deps)) {
- public_deps = invoker.public_deps
+ public_deps += invoker.public_deps
}
}
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | sky/engine/core/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698