Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: mojo/public/tools/bindings/mojom.gni

Issue 663483006: Fix sky to pass 'gn check' (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Moar redundant Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | sky/engine/core/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Generate C++ and JavaScript source files from mojom files. The output files 5 # Generate C++ and JavaScript source files from mojom files. The output files
6 # will go under the generated file directory tree with the same path as each 6 # will go under the generated file directory tree with the same path as each
7 # input file. 7 # input file.
8 # 8 #
9 # Parameters: 9 # Parameters:
10 # 10 #
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 source_set(target_name) { 129 source_set(target_name) {
130 if (defined(invoker.visibility)) { 130 if (defined(invoker.visibility)) {
131 visibility = invoker.visibility 131 visibility = invoker.visibility
132 } 132 }
133 if (defined(invoker.testonly)) { 133 if (defined(invoker.testonly)) {
134 testonly = invoker.testonly 134 testonly = invoker.testonly
135 } 135 }
136 sources = process_file_template(invoker.sources, generator_cpp_outputs) 136 sources = process_file_template(invoker.sources, generator_cpp_outputs)
137 data = process_file_template(invoker.sources, generator_js_outputs) 137 data = process_file_template(invoker.sources, generator_js_outputs)
138 deps = [ 138 deps = [
jamesr 2014/10/24 21:42:47 can be one line now deps = [ "//mojo/public/cpp/b
139 ":$generator_target_name",
140 "//mojo/public/cpp/bindings", 139 "//mojo/public/cpp/bindings",
141 ] 140 ]
142 if (defined(invoker.deps)) { 141 if (defined(invoker.deps)) {
143 deps += invoker.deps 142 deps += invoker.deps
144 } 143 }
144 public_deps = [
jamesr 2014/10/24 21:42:47 one line
145 ":$generator_target_name",
146 ]
145 if (defined(invoker.public_deps)) { 147 if (defined(invoker.public_deps)) {
146 public_deps = invoker.public_deps 148 public_deps += invoker.public_deps
147 } 149 }
148 } 150 }
abarth-chromium 2014/10/24 21:38:10 We should have someone else look at this part of t
149 151
150 all_deps = [] 152 all_deps = []
151 if (defined(invoker.deps)) { 153 if (defined(invoker.deps)) {
152 all_deps += invoker.deps 154 all_deps += invoker.deps
153 } 155 }
154 if (defined(invoker.public_deps)) { 156 if (defined(invoker.public_deps)) {
155 all_deps += invoker.public_deps 157 all_deps += invoker.public_deps
156 } 158 }
157 159
158 group("${target_name}__is_mojom") { 160 group("${target_name}__is_mojom") {
(...skipping 25 matching lines...) Expand all
184 # //mojo/something:something and we can append "_java" to get the java 186 # //mojo/something:something and we can append "_java" to get the java
185 # dependency name. 187 # dependency name.
186 full_name = get_label_info(d, "label_no_toolchain") 188 full_name = get_label_info(d, "label_no_toolchain")
187 deps += [ "${full_name}_java" ] 189 deps += [ "${full_name}_java" ]
188 } 190 }
189 191
190 srcjars = process_file_template(invoker.sources, generator_java_outputs) 192 srcjars = process_file_template(invoker.sources, generator_java_outputs)
191 } 193 }
192 } 194 }
193 } 195 }
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/BUILD.gn » ('j') | sky/engine/core/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698