Fix sky to pass 'gn check'

Fix sky to pass 'gn check'

I also deleted the sky_common and sky_minimal targets
as those were only for the windows build
(which sky does not support).

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ca54f561bab6853ae8231968acf78523286b6bfc

[eseidel, 2014-10-24 21:27:12]

eseidel@chromium.org changed reviewers:
+ abarth@chromium.org, brettw@chromium.org

[eseidel, 2014-10-24 21:32:03]

https://codereview.chromium.org/663483006/diff/1/sky/engine/core/BUILD.gn
File sky/engine/core/BUILD.gn (right):

https://codereview.chromium.org/663483006/diff/1/sky/engine/core/BUILD.gn#new...
sky/engine/core/BUILD.gn:14: public_deps = [
Libraries exists just to have one place to list all the deps for various sky
targets, so it makes sense that it's deps would be public.

[abarth-chromium, 2014-10-24 21:38:11]

https://codereview.chromium.org/663483006/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/mojom.gni (right):

https://codereview.chromium.org/663483006/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/mojom.gni:150: }
We should have someone else look at this part of the change.

Otherwise, LGTM

[jamesr, 2014-10-24 21:42:46]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-10-24 21:42:47]

Can you point me at a place that needs the mojom public_deps change?  It's not
obvious to me that's necessary

https://codereview.chromium.org/663483006/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/mojom.gni (right):

https://codereview.chromium.org/663483006/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/mojom.gni:138: deps = [
can be one line now

deps = [ "//mojo/public/cpp/bindings" ]

https://codereview.chromium.org/663483006/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/mojom.gni:144: public_deps = [
one line

https://codereview.chromium.org/663483006/diff/40001/sky/engine/core/BUILD.gn
File sky/engine/core/BUILD.gn (right):

https://codereview.chromium.org/663483006/diff/40001/sky/engine/core/BUILD.gn...
sky/engine/core/BUILD.gn:14: public_deps = [
i assume you're gonna tighten this up at some point? surely we don't expose all
of these in core's public headers

[eseidel, 2014-10-24 21:56:56]

Looks like the mojom.gni change was not necessary.  i've removed it.

:libraries is an internal target, is there a better way for us to do that?  We
could also have all 6 targets which depend on :libraries include all of those
deps directly?

[jamesr, 2014-10-24 21:57:27]

On 2014/10/24 21:56:56, eseidel wrote:
> Looks like the mojom.gni change was not necessary.  i've removed it.
> 
> :libraries is an internal target, is there a better way for us to do that?  We
> could also have all 6 targets which depend on :libraries include all of those
> deps directly?

Could you show me the error you're getting?

[eseidel, 2014-10-24 22:00:58]

Committed patchset #4 (id:60001) manually as
ca54f561bab6853ae8231968acf78523286b6bfc (presubmit successful).