Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 663483005: Revert of Close the select box when the parent RWHVA loses focus (Closed)

Created:
6 years, 2 months ago by yzshen1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Close the select box when the parent RWHVA loses focus (patchset #2 id:170001 of https://codereview.chromium.org/652793003/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(1): RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (run #1): [ RUN ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus Xlib: extension "RANDR" missing on display ":9". ../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:875: Failure Value of: observer.destroyed() Actual: false Expected: true [ FAILED ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (10 ms) Original issue's description: > Close the select box when the parent RWHVA loses focus > > BUG=422264, 414550 > TEST=RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus > > Committed: https://crrev.com/1f909ee8c8ae5cbc92416482374d2228f087684c > Cr-Commit-Position: refs/heads/master@{#301108} TBR=tkent@chromium.org,ben@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=422264, 414550 Committed: https://crrev.com/ded5e3c8493a3e5559e49986de163f2c0bc3fbc3 Cr-Commit-Position: refs/heads/master@{#301127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -50 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +8 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
Created Revert of Close the select box when the parent RWHVA loses focus
6 years, 2 months ago (2014-10-24 16:56:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663483005/1
6 years, 2 months ago (2014-10-24 16:57:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 16:59:02 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 17:00:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded5e3c8493a3e5559e49986de163f2c0bc3fbc3
Cr-Commit-Position: refs/heads/master@{#301127}

Powered by Google App Engine
This is Rietveld 408576698