extensions/renderer/resources/guest_view/web_view_constants.js - Issue 663483004: Webview attributes overhaul.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view_constants.js

Issue 663483004: Webview attributes overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/guest_view/web_view_constants.js

diff --git a/extensions/renderer/resources/guest_view/web_view_constants.js b/extensions/renderer/resources/guest_view/web_view_constants.js

index dd902aae232f494d58946d09e4d35b28523351f9..40cf6ba22343348c234ef227e364cec6527b6e42 100644

--- a/extensions/renderer/resources/guest_view/web_view_constants.js

+++ b/extensions/renderer/resources/guest_view/web_view_constants.js

@@ -13,7 +13,12 @@ var WebViewConstants = {

ATTRIBUTE_MAXWIDTH: 'maxwidth',

ATTRIBUTE_MINHEIGHT: 'minheight',

ATTRIBUTE_MINWIDTH: 'minwidth',

+ ATTRIBUTE_NAME: 'name',

ATTRIBUTE_PARTITION: 'partition',

+ ATTRIBUTE_SRC: 'src',

+ // Internal attribute.

+ ATTRIBUTE_INTERNALINSTANCEID: 'internalinstanceid',

// Error messages.

ERROR_MSG_ALREADY_NAVIGATED:

« no previous file with comments | « extensions/renderer/resources/guest_view/web_view_attributes.js ('k') | no next file » | no next file with comments »