Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: extensions/renderer/resources/guest_view/web_view_constants.js

Issue 663483004: Webview attributes overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view_attributes.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module contains constants used in webview. 5 // This module contains constants used in webview.
6 6
7 // Container for the webview constants. 7 // Container for the webview constants.
8 var WebViewConstants = { 8 var WebViewConstants = {
9 // Attributes. 9 // Attributes.
10 ATTRIBUTE_ALLOWTRANSPARENCY: 'allowtransparency', 10 ATTRIBUTE_ALLOWTRANSPARENCY: 'allowtransparency',
11 ATTRIBUTE_AUTOSIZE: 'autosize', 11 ATTRIBUTE_AUTOSIZE: 'autosize',
12 ATTRIBUTE_MAXHEIGHT: 'maxheight', 12 ATTRIBUTE_MAXHEIGHT: 'maxheight',
13 ATTRIBUTE_MAXWIDTH: 'maxwidth', 13 ATTRIBUTE_MAXWIDTH: 'maxwidth',
14 ATTRIBUTE_MINHEIGHT: 'minheight', 14 ATTRIBUTE_MINHEIGHT: 'minheight',
15 ATTRIBUTE_MINWIDTH: 'minwidth', 15 ATTRIBUTE_MINWIDTH: 'minwidth',
16 ATTRIBUTE_NAME: 'name',
16 ATTRIBUTE_PARTITION: 'partition', 17 ATTRIBUTE_PARTITION: 'partition',
18 ATTRIBUTE_SRC: 'src',
19
20 // Internal attribute.
21 ATTRIBUTE_INTERNALINSTANCEID: 'internalinstanceid',
17 22
18 // Error messages. 23 // Error messages.
19 ERROR_MSG_ALREADY_NAVIGATED: 24 ERROR_MSG_ALREADY_NAVIGATED:
20 'The object has already navigated, so its partition cannot be changed.', 25 'The object has already navigated, so its partition cannot be changed.',
21 ERROR_MSG_CANNOT_INJECT_SCRIPT: '<webview>: ' + 26 ERROR_MSG_CANNOT_INJECT_SCRIPT: '<webview>: ' +
22 'Script cannot be injected into content until the page has loaded.', 27 'Script cannot be injected into content until the page has loaded.',
23 ERROR_MSG_CONTENTWINDOW_NOT_AVAILABLE: '<webview>: ' + 28 ERROR_MSG_CONTENTWINDOW_NOT_AVAILABLE: '<webview>: ' +
24 'contentWindow is not available at this time. It will become available ' + 29 'contentWindow is not available at this time. It will become available ' +
25 'when the page has finished loading.', 30 'when the page has finished loading.',
26 ERROR_MSG_INVALID_PARTITION_ATTRIBUTE: 'Invalid partition attribute.' 31 ERROR_MSG_INVALID_PARTITION_ATTRIBUTE: 'Invalid partition attribute.'
27 }; 32 };
28 33
29 exports.WebViewConstants = WebViewConstants; 34 exports.WebViewConstants = WebViewConstants;
OLDNEW
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view_attributes.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698