Add non-native file handling in FileSelectorHelper class.

chrome/browser/file_select_helper.h

Index: chrome/browser/file_select_helper.h
diff --git a/chrome/browser/file_select_helper.h b/chrome/browser/file_select_helper.h
index f71a92f164f92d622554a473da6475eed4760afc..20111a6d0209a66886edfbde6c5d98a04b13dfbf 100644
--- a/chrome/browser/file_select_helper.h
+++ b/chrome/browser/file_select_helper.h
@@ -19,6 +19,7 @@
 class Profile;
 
 namespace content {
+struct FileChooserFileInfo;
 class RenderViewHost;
 class WebContents;
 }
@@ -140,10 +141,22 @@ class FileSelectHelper
   static base::FilePath ZipPackage(const base::FilePath& path);
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
+#if defined(OS_CHROMEOS)
+  // Converts |files| into FileChooserFileInfo with handling non-native files.

[Avi (use Gerrit), 2014/10/16 15:21:20]

... with handling of non-native files.

[hirono, 2014/10/17 11:42:10]

Done.

+  void ProcessSelectedFilesChromeOS(
+      const std::vector<ui::SelectedFileInfo>& files);
+
+  // Passes the result to |NotifyRenderViewHostAndEnd|.
+  void ProcessSelectedFilesChromeOSAfterConvresion(

[Avi (use Gerrit), 2014/10/16 15:21:20]

...AfterConversion

[hirono, 2014/10/17 11:42:10]

Done.

+      scoped_ptr<std::vector<content::FileChooserFileInfo>> list);
+#endif  // defined(OS_CHROMEOS)
+
+  void ProcessSelectedFiles(const std::vector<ui::SelectedFileInfo>& files);

[Avi (use Gerrit), 2014/10/16 15:21:20]

Is ProcessSelectedFiles mutually exclusive with ProcessSelectedFilesChromeOS?
Would the former never be called on ChromeOS? If so, we shouldn't have two
functions but one. If not, then it's not clear which one should be called over
the other.

Where is the comment explaining the purpose here?

[hirono, 2014/10/17 11:42:10]

I combined the two function. Added a comment.

+
   // Utility method that passes |files| to the render view host, and ends the
   // file chooser.

[Avi (use Gerrit), 2014/10/16 15:21:20]

Is this no longer supposed to be called? It seems like you've moved callers to
ProcessSelectedFiles, so when is this now supposed to be called? Move this to
the private section if it's no longer supposed to be called from the outside.

[hirono, 2014/10/17 11:42:10]

Done.

   void NotifyRenderViewHostAndEnd(
-      const std::vector<ui::SelectedFileInfo>& files);
+      const std::vector<content::FileChooserFileInfo>& files);
 
   // Schedules the deletion of the files in |temporary_files_| and clears the
   // vector.