Abort ImportantFileWriter::WriteFileAtomically() on Flush() error.

base/files/important_file_writer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
@@ skipping 15 matching lines @@
 namespace {
 
 const int kDefaultCommitIntervalMs = 10000;
 
 enum TempFileFailure {
   FAILED_CREATING,
   FAILED_OPENING,
   FAILED_CLOSING,
   FAILED_WRITING,
   FAILED_RENAMING,
+  FAILED_FLUSHING,
   TEMP_FILE_FAILURE_MAX
 };
 
 void LogFailure(const FilePath& path, TempFileFailure failure_code,
                 const std::string& message) {
   UMA_HISTOGRAM_ENUMERATION("ImportantFile.TempFileFailures", failure_code,
                             TEMP_FILE_FAILURE_MAX);
   DPLOG(WARNING) << "temp file failure: " << path.value().c_str()
                  << " : " << message;
 }
@@ skipping 16 matching lines @@
   File tmp_file(tmp_file_path, File::FLAG_OPEN | File::FLAG_WRITE);
   if (!tmp_file.IsValid()) {
     LogFailure(path, FAILED_OPENING, "could not open temporary file");
     return false;
   }
 
   // If this happens in the wild something really bad is going on.
   CHECK_LE(data.length(), static_cast<size_t>(kint32max));
   int bytes_written = tmp_file.Write(0, data.data(),
                                      static_cast<int>(data.length()));
-  tmp_file.Flush();  // Ignore return value.
+  bool flush_success = tmp_file.Flush();
   tmp_file.Close();
 
   if (bytes_written < static_cast<int>(data.length())) {
     LogFailure(path, FAILED_WRITING, "error writing, bytes_written=" +
                IntToString(bytes_written));
     base::DeleteFile(tmp_file_path, false);
     return false;
   }
 
+  if (!flush_success) {
+    LogFailure(path, FAILED_FLUSHING, "error flushing");
+    base::DeleteFile(tmp_file_path, false);
+    return false;
+  }
+
   if (!base::ReplaceFile(tmp_file_path, path, NULL)) {
     LogFailure(path, FAILED_RENAMING, "could not rename temporary file");
     base::DeleteFile(tmp_file_path, false);
     return false;
   }
 
   return true;
 }
 
 ImportantFileWriter::ImportantFileWriter(
@@ skipping 94 matching lines @@
 
 void ImportantFileWriter::ForwardSuccessfulWrite(bool result) {
   DCHECK(CalledOnValidThread());
   if (result && !on_next_successful_write_.is_null()) {
     on_next_successful_write_.Run();
     on_next_successful_write_.Reset();
   }
 }
 
 }  // namespace base