Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 663453003: DevTools: [Elements] fix editing as HTML inplace editor scrolling (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [Elements] fix editing as HTML inplace editor scrolling The patch prevents ElementTreeELements from selecting if they have inner inplace editor. BUG=423720 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
Please, take a look
6 years, 2 months ago (2014-10-16 11:34:40 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-16 11:37:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663453003/1
6 years, 2 months ago (2014-10-16 11:37:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 12:37:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183809

Powered by Google App Engine
This is Rietveld 408576698