Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 66343004: [NaCl SDK] ppapi_simple: Allow initial terminal size to to be set on startup. (Closed)

Created:
7 years, 1 month ago by Sam Clegg
Modified:
7 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] ppapi_simple: Allow initial terminal size to to be set on startup. Allow the initial terminal size to be set via the PS_TTY_ROWS and PS_TTY_COLS environment variables. This allows ppapi_simple application to know the TTY size before the main function runs. R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234130

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M native_client_sdk/src/libraries/nacl_io/mount_node_tty.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc View 1 2 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
7 years, 1 month ago (2013-11-09 00:50:15 UTC) #1
binji
lgtm https://codereview.chromium.org/66343004/diff/1/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right): https://codereview.chromium.org/66343004/diff/1/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc#newcode244 native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:244: HandleResize(atoi(tty_cols), atoi(tty_rows)); better error messaging here? What if ...
7 years, 1 month ago (2013-11-09 00:55:07 UTC) #2
Sam Clegg
https://codereview.chromium.org/66343004/diff/1/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right): https://codereview.chromium.org/66343004/diff/1/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc#newcode244 native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:244: HandleResize(atoi(tty_cols), atoi(tty_rows)); On 2013/11/09 00:55:08, binji wrote: > better ...
7 years, 1 month ago (2013-11-09 01:12:58 UTC) #3
binji
slgtm
7 years, 1 month ago (2013-11-09 01:33:51 UTC) #4
Sam Clegg
7 years, 1 month ago (2013-11-09 17:34:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r234130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698