events: Run events_unittests on the bots.

events: Run events_unittests on the bots.

events_unittests is a new target that should run when views or aura is turned
on, so on Windows, ChromeOS, and on Linux Aura.

BUG=316677
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234418

[sadrul, 2013-11-08 20:34:24]

The new target is added in https://codereview.chromium.org/66663004/

There are currently 20 tests, and it takes ~0.1s to complete. These tests are
currently already run in the bots as part of ui_unittests. So running as a
separate target should not introduce regressions in the bots.

I looked at all the places where aura_unittests is mentioned, and added this new
target there too.

[M-A Ruel, 2013-11-08 20:40:11]

On 2013/11/08 20:34:24, sadrul wrote:
> The new target is added in https://codereview.chromium.org/66663004/
> 
> There are currently 20 tests, and it takes ~0.1s to complete. These tests are
> currently already run in the bots as part of ui_unittests. So running as a
> separate target should not introduce regressions in the bots.
> 
> I looked at all the places where aura_unittests is mentioned, and added this
new
> target there too.

Tentatively redirecting to stip
I don't review build steps management anymore.

[ghost stip (do not use), 2013-11-11 22:45:54]

lgtm with comment

https://chromiumcodereview.appspot.com/66343003/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/66343003/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:420: 'events_br',
note that the buildrunner tests will go live once committed, no restart needed

https://chromiumcodereview.appspot.com/66343003/diff/1/scripts/master/factory...
File scripts/master/factory/chromium_factory.py (right):

https://chromiumcodereview.appspot.com/66343003/diff/1/scripts/master/factory...
scripts/master/factory/chromium_factory.py:485: if R('events') or
R('events_unittests'):
why have both of these? let's just stick with 'events'

[sadrul, 2013-11-12 05:04:47]

https://codereview.chromium.org/66343003/diff/1/scripts/master/factory/chromi...
File scripts/master/factory/chromium_factory.py (right):

https://codereview.chromium.org/66343003/diff/1/scripts/master/factory/chromi...
scripts/master/factory/chromium_factory.py:485: if R('events') or
R('events_unittests'):
On 2013/11/11 22:45:55, stip wrote:
> why have both of these? let's just stick with 'events'

Done.

[commit-bot: I haz the power, 2013-11-12 05:31:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sadrul@chromium.org/66343003/70001

[commit-bot: I haz the power, 2013-11-12 05:32:34]

Change committed as 234418

[jam, 2013-11-12 16:04:33]

note: new targets should be on win_rel, since win_aura is going away in
http://code.google.com/p/chromium/issues/detail?id=316199. win_rel is anyways
aura, so it should have the aura specific test targets as well.

I have updated my cl in https://codereview.chromium.org/66063002/ to do this,
please double check it and also keep this in mind for the next cls. Thanks.

[sadrul, 2013-11-12 16:11:36]

On 2013/11/12 16:04:33, jam wrote:
> note: new targets should be on win_rel, since win_aura is going away in
> http://code.google.com/p/chromium/issues/detail?id=316199. win_rel is anyways
> aura, so it should have the aura specific test targets as well.
> 
> I have updated my cl in https://codereview.chromium.org/66063002/ to do this,
> please double check it and also keep this in mind for the next cls. Thanks.

Noted. Thanks for the fix!