Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 663393002: Added histograms for newly added use counters. (Closed)

Created:
6 years, 2 months ago by Yoav Weiss
Modified:
6 years, 2 months ago
Reviewers:
Mike West, *Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added histograms for newly added use counters. Following https://codereview.chromium.org/649183007/ , I've updated the histograms file on the Chrome side. Committed: https://crrev.com/f6495730cb973fb920701f04af53ee635bf44f38 Cr-Commit-Position: refs/heads/master@{#300638}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Yoav Weiss
6 years, 2 months ago (2014-10-21 12:30:37 UTC) #2
Mike West
1. This doesn't seem to apply cleanly. I assume one or the other item has ...
6 years, 2 months ago (2014-10-21 12:41:59 UTC) #4
Yoav Weiss
On 2014/10/21 12:41:59, Mike West wrote: > 1. This doesn't seem to apply cleanly. I ...
6 years, 2 months ago (2014-10-21 12:47:42 UTC) #5
Mike West
LGTM, but you'll need Ilya.
6 years, 2 months ago (2014-10-21 13:27:46 UTC) #7
Ilya Sherman
LGTM
6 years, 2 months ago (2014-10-21 21:11:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663393002/20001
6 years, 2 months ago (2014-10-21 21:15:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/66066)
6 years, 2 months ago (2014-10-21 21:35:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663393002/20001
6 years, 2 months ago (2014-10-21 21:37:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/66066)
6 years, 2 months ago (2014-10-21 22:10:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663393002/20001
6 years, 2 months ago (2014-10-22 05:55:42 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 05:56:20 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 05:56:58 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6495730cb973fb920701f04af53ee635bf44f38
Cr-Commit-Position: refs/heads/master@{#300638}

Powered by Google App Engine
This is Rietveld 408576698