Issue 663373005: Revert 4939383c95030cf963cf5a70ede23c57b212baa4 from M38

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 663373005: Revert 4939383c95030cf963cf5a70ede23c57b212baa4 from M38 (Closed)

Created:
6 years, 2 months ago by scottmg

Modified:
6 years, 2 months ago

Reviewers:
Alexei Svitkine (slow), ckocagil, msw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

Revert 4939383c95030cf963cf5a70ede23c57b212baa4 from M38 Causing blanks/boxes on mixed CJK configurations. A direct revert wasn't sufficient, I had to add internal:: to LinkedFontsIterator and re-add the implementation of ChooseFallbackFont. R=ckocagil@chromium.org, asvitkine@chromium.org BUG=422142 TEST=zh-hans WinXP, Chrome UI set to Korean, things don't disappear Committed: https://chromium.googlesource.com/chromium/src/+/0af48d1ec0eb6189687f929b7fea6ff4b41127c9

Created: 6 years, 2 months ago

		Unified diffs	Side-by-side diffs	Stats (+116 lines, -62 lines)
	M	ui/gfx/render_text_win.h	View	1 chunk	+1 line, -2 lines	0 comments
	M	ui/gfx/render_text_win.cc	View	3 chunks	+115 lines, -60 lines	0 comments

Total messages: 7 (1 generated)

scottmg

Committed patchset #1 (id:1) manually as 0af48d1ec0eb6189687f929b7fea6ff4b41127c9.

6 years, 2 months ago (2014-10-21 23:35:04 UTC) #5

Message was sent while issue was closed.

lgtm