Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 663373003: Assign bailout and type feedback IDs in a post-pass (Closed)

Created:
6 years, 2 months ago by wingo
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Assign bailout and type feedback IDs in a post-pass This will allow us to move expressions from one function to another, for example when the parser determines that a given cover grammar instance is actually the default value initializer for an arrow function. This is a re-land of https://codereview.chromium.org/636403003/ with a fix for the arm64 code generator. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+810 lines, -378 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M src/ast.h View 71 chunks +301 lines, -321 lines 0 comments Download
M src/ast.cc View 4 chunks +8 lines, -9 lines 0 comments Download
A src/ast-numbering.h View 1 chunk +19 lines, -0 lines 0 comments Download
A src/ast-numbering.cc View 1 chunk +416 lines, -0 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/parser.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/preparser.h View 8 chunks +5 lines, -10 lines 0 comments Download
M src/preparser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/rewriter.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 3 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
PTAL. This is the same as https://codereview.chromium.org/636403003/ with a fix to make the arm64 code ...
6 years, 2 months ago (2014-10-21 11:27:14 UTC) #1
Sven Panne
LGTM. I assume the only change compared to the previous CL is in src/arm64/full-codegen-arm64.cc, correct? ...
6 years, 2 months ago (2014-10-21 12:03:42 UTC) #2
wingo
On 2014/10/21 12:03:42, Sven Panne wrote: > LGTM. I assume the only change compared to ...
6 years, 2 months ago (2014-10-21 12:11:54 UTC) #3
wingo
6 years, 2 months ago (2014-10-21 12:17:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698