Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 663373002: [DevTools] Add implementation for Tracing.start with optional parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/tracing_handler.h
diff --git a/content/browser/devtools/protocol/tracing_handler.h b/content/browser/devtools/protocol/tracing_handler.h
index d2fc77307b92cd2fa0238089ca170c9c8b3d70a8..c629188b73d77df6eda9035f09b0265707cb320c 100644
--- a/content/browser/devtools/protocol/tracing_handler.h
+++ b/content/browser/devtools/protocol/tracing_handler.h
@@ -20,18 +20,17 @@ class TracingHandler {
void SetClient(scoped_ptr<Client> client);
- // TODO(dgozman): remove sync version after migration.
- Response Start(const std::string& categories,
- const std::string& options,
- const double* buffer_usage_reporting_interval);
scoped_refptr<DevToolsProtocol::Response> Start(
const std::string& categories,
const std::string& options,
const double* buffer_usage_reporting_interval,
scoped_refptr<DevToolsProtocol::Command> command);
+ scoped_refptr<DevToolsProtocol::Response> Start(
+ const std::string* categories,
+ const std::string* options,
+ const double* buffer_usage_reporting_interval,
+ scoped_refptr<DevToolsProtocol::Command> command);
- // TODO(dgozman): remove sync version after migration.
- Response End();
scoped_refptr<DevToolsProtocol::Response> End(
scoped_refptr<DevToolsProtocol::Command> command);
« no previous file with comments | « no previous file | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698