Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 663373002: [DevTools] Add implementation for Tracing.start with optional parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/tracing_handler.cc
diff --git a/content/browser/devtools/protocol/tracing_handler.cc b/content/browser/devtools/protocol/tracing_handler.cc
index a57fdb8df7d74aac235a7a0ecacddc05c8e32b47..f4ce95b8ce3505d5806b4cf73e4efe05bca0e00d 100644
--- a/content/browser/devtools/protocol/tracing_handler.cc
+++ b/content/browser/devtools/protocol/tracing_handler.cc
@@ -20,12 +20,6 @@ void TracingHandler::SetClient(scoped_ptr<Client> client) {
client_.swap(client);
}
-Response TracingHandler::Start(const std::string& categories,
- const std::string& options,
- const double* buffer_usage_reporting_interval) {
- return Response::FallThrough();
-}
-
scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
const std::string& categories,
const std::string& options,
@@ -34,8 +28,12 @@ scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
return NULL;
}
-Response TracingHandler::End() {
- return Response::FallThrough();
+scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
+ const std::string* categories,
+ const std::string* options,
+ const double* buffer_usage_reporting_interval,
+ scoped_refptr<DevToolsProtocol::Command> command) {
+ return NULL;
}
scoped_refptr<DevToolsProtocol::Response> TracingHandler::End(
« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698