Issue 663373002: [DevTools] Add implementation for Tracing.start with optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 663373002: [DevTools] Add implementation for Tracing.start with optional parameters. (Closed)

Created:
6 years, 2 months ago by dgozman

Modified:
6 years, 2 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Add implementation for Tracing.start with optional parameters. BUG=405566 TBR=pfeldman Committed: https://crrev.com/3059e6ea2338193df1933801f0ea7dbbdec1960c Cr-Commit-Position: refs/heads/master@{#300477}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	content/browser/devtools/protocol/tracing_handler.h	View		1 chunk	+5 lines, -6 lines	0 comments	Download
	M	content/browser/devtools/protocol/tracing_handler.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663373002/1

6 years, 2 months ago (2014-10-21 11:05:23 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 13:10:15 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3059e6ea2338193df1933801f0ea7dbbdec1960c
Cr-Commit-Position: refs/heads/master@{#300477}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages