Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 663333005: Disable OOL constant pool for Arm. (Closed)

Created:
6 years, 1 month ago by rmcilroy
Modified:
6 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Disable OOL constant pool for Arm. This caused some performance regressions on Octane. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/globals.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmcilroy
Off again... PTAL, thanks.
6 years, 1 month ago (2014-10-27 22:40:30 UTC) #2
ulan
lgtm
6 years, 1 month ago (2014-10-28 08:56:09 UTC) #3
rmcilroy
6 years, 1 month ago (2014-10-28 16:25:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698