Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 663333004: Remove proxy retry time condition from CORS bypass integration test. (Closed)

Created:
6 years, 1 month ago by sclittle
Modified:
6 years, 1 month ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove proxy retry time condition from CORS bypass integration test. This fixes the failing CORS bypass telemetry test for the data reduction proxy. The CORS bypass test doesn't need to care what kind of bypass was caused, just that the CORS request was bypassed. Also made VerifyProxyInfo resilient to the actual and expected proxy lists being ordered differently. BUG=423916 Committed: https://crrev.com/7e150a9045108133f5515342f1da6fcc3c23eff8 Cr-Commit-Position: refs/heads/master@{#301472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sclittle
bolian, bengr: all Thanks in advance
6 years, 1 month ago (2014-10-27 20:45:56 UTC) #2
bengr
lgtm
6 years, 1 month ago (2014-10-27 21:16:42 UTC) #3
bengr
On 2014/10/27 21:16:42, bengr wrote: > lgtm This needs a bug number
6 years, 1 month ago (2014-10-27 21:16:54 UTC) #4
bolian
lgtm
6 years, 1 month ago (2014-10-27 21:17:57 UTC) #5
sclittle
Added bug number to CL description.
6 years, 1 month ago (2014-10-27 21:29:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663333004/1
6 years, 1 month ago (2014-10-27 21:31:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:14:01 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:14:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e150a9045108133f5515342f1da6fcc3c23eff8
Cr-Commit-Position: refs/heads/master@{#301472}

Powered by Google App Engine
This is Rietveld 408576698