Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663333003: [turbofan] use ZonePool in most places in the compiler pipeline a temp zone is used. (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] use ZonePool in most places in the compiler pipeline a temp zone is used. R=jarin@chromium.org, bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24779

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -92 lines) Patch
M src/compiler/ast-graph-builder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/control-reducer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M src/compiler/graph-builder.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/graph-builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 9 chunks +25 lines, -15 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 6 chunks +11 lines, -18 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 4 chunks +47 lines, -24 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-21 13:38:09 UTC) #2
Jarin
lgtm
6 years, 2 months ago (2014-10-21 14:01:44 UTC) #4
dcarney
6 years, 2 months ago (2014-10-21 14:45:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 24779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698