Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 66333016: Add DirectWrite flag and plumb it through to Blink (Closed)

Created:
7 years, 1 month ago by eae
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add DirectWrite flag and plumb it through to Blink Add an "enable-direct-write" flag and plumb it through to WebRuntimeFeatures on the Blink side. R=abarth@chromium.org BUG=25541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239354

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 5

Patch Set 3 : Added if(WIN) checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
eae
7 years, 1 month ago (2013-11-13 21:34:57 UTC) #1
eae
The blink side of this change has landed so the bots should like it better ...
7 years, 1 month ago (2013-11-13 22:05:37 UTC) #2
dglazkov
lgtm!
7 years, 1 month ago (2013-11-14 21:05:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/120001
7 years, 1 month ago (2013-11-14 21:06:26 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36291
7 years, 1 month ago (2013-11-14 21:26:40 UTC) #5
eae
Needs OWNERS approval: Missing LGTM from an OWNER for these files: content/browser/renderer_host/render_process_host_impl.cc content/child/runtime_features.cc content/public/common/content_switches.cc content/public/common/content_switches.h
7 years, 1 month ago (2013-11-14 21:34:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/120001
7 years, 1 month ago (2013-11-14 21:34:34 UTC) #7
eae
Need OWNERS approval
7 years, 1 month ago (2013-11-14 21:45:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/120001
7 years, 1 month ago (2013-11-14 22:05:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/120001
7 years, 1 month ago (2013-11-15 01:49:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/120001
7 years, 1 month ago (2013-11-15 04:03:29 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36491
7 years, 1 month ago (2013-11-15 05:33:40 UTC) #12
eae
7 years, 1 month ago (2013-11-15 22:41:17 UTC) #13
Avi (use Gerrit)
https://codereview.chromium.org/66333016/diff/120001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/66333016/diff/120001/chrome/app/generated_resources.grd#newcode5860 chrome/app/generated_resources.grd:5860: + Enables the use of experimental DirectWrite font rendering ...
7 years, 1 month ago (2013-11-16 06:26:50 UTC) #14
eae
Thanks Avi, I made the changes you suggested. Please take another look when you get ...
7 years ago (2013-12-05 23:25:59 UTC) #15
Avi (use Gerrit)
LGTM!
7 years ago (2013-12-05 23:43:04 UTC) #16
eae
On 2013/12/05 23:43:04, Avi wrote: > LGTM! Thanks!
7 years ago (2013-12-05 23:43:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/580001
7 years ago (2013-12-06 00:03:37 UTC) #18
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32345
7 years ago (2013-12-06 05:10:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/580001
7 years ago (2013-12-07 01:02:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/66333016/580001
7 years ago (2013-12-07 22:30:53 UTC) #22
commit-bot: I haz the power
7 years ago (2013-12-07 22:32:09 UTC) #23
Message was sent while issue was closed.
Change committed as 239354

Powered by Google App Engine
This is Rietveld 408576698