Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1511)

Issue 66333012: [NaCl AddIn] Update location of PNaCl executables. (Closed)

Created:
7 years, 1 month ago by Sam Clegg
Modified:
7 years, 1 month ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl AddIn] Update location of PNaCl executables. This changed with pepper_30 but the addin was not updated. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1565

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Microsoft.Cpp.PNaCl.targets View 1 3 chunks +3 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/buildbot_run.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
Ooops, should not have let this one slip through the cracks for so long.
7 years, 1 month ago (2013-11-13 01:14:20 UTC) #1
binji
lgtm
7 years, 1 month ago (2013-11-13 01:17:38 UTC) #2
Sam Clegg
7 years, 1 month ago (2013-11-13 01:25:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r1565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698