Source/core/css/CSSPrimitiveValueMappings.h - Issue 663313005: Comply Compositing spec [1]; remove 'plus-darker'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 663313005: Comply Compositing spec [1]; remove 'plus-darker'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Mark virtual/display_list_2d_canvas/fast/canvas/canvas-composite NeedsRebaseline Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/gpu/canvas/philip/tests/2d.composite.operation.darker-expected.txt ('k') | Source/core/css/CSSValueKeywords.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h

index 122b07884f9fb5efffe2fc53b32b72e576f55992..b65c8cc89929120b2dd013efc053b50d950de06b 100644

--- a/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/Source/core/css/CSSPrimitiveValueMappings.h

@@ -348,13 +348,10 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(CompositeOperator e)

case CompositeXOR:

m_value.valueID = CSSValueXor;

break;

- case CompositePlusDarker:

- m_value.valueID = CSSValuePlusDarker;

- break;

case CompositePlusLighter:

m_value.valueID = CSSValuePlusLighter;

break;

- case CompositeDifference:

+ default:

ASSERT_NOT_REACHED();

break;

}

@@ -386,8 +383,6 @@ template<> inline CSSPrimitiveValue::operator CompositeOperator() const

return CompositeDestinationAtop;

case CSSValueXor:

return CompositeXOR;

- case CSSValuePlusDarker:

- return CompositePlusDarker;

case CSSValuePlusLighter:

return CompositePlusLighter;

default: