Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 663313003: Cleanup ConsStringIteratorOp. (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Cleanup ConsStringIteratorOp. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24818

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -141 lines) Patch
M src/codegen.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate.h View 5 chunks +0 lines, -19 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/objects.h View 1 3 chunks +5 lines, -19 lines 0 comments Download
M src/objects.cc View 1 2 14 chunks +20 lines, -38 lines 0 comments Download
M src/objects-inl.h View 1 2 5 chunks +12 lines, -17 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -21 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/string-stream.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-strings.cc View 1 4 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-21 14:33:32 UTC) #2
Yang
On 2014/10/21 14:33:32, dcarney wrote: > ptal LGTM.
6 years, 2 months ago (2014-10-22 12:19:44 UTC) #3
dcarney
6 years, 2 months ago (2014-10-23 05:57:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698