Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 663293004: [ServiceWorker] Fix test failure of registration.html (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
nhiroki, dmurph
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Fix test failure of registration.html This bug is introduced by https://codereview.chromium.org/647953003. The error status must be passed to script_cache_map. It will be checked in ServiceWorkerRegisterJob::OnStartWorkerFinished() and use to handle the error in JS. BUG=425430 TBR=dmurph Committed: https://crrev.com/e611a5f637f0a94142de7914848586a13b24f221 Cr-Commit-Position: refs/heads/master@{#300430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
horo
nhiroki@ Could you please review?
6 years, 2 months ago (2014-10-21 05:50:37 UTC) #2
nhiroki
lgtm
6 years, 2 months ago (2014-10-21 05:59:04 UTC) #3
horo
Thank you!
6 years, 2 months ago (2014-10-21 06:26:47 UTC) #5
horo
6 years, 2 months ago (2014-10-21 06:26:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663293004/1
6 years, 2 months ago (2014-10-21 06:27:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 07:19:55 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 07:20:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e611a5f637f0a94142de7914848586a13b24f221
Cr-Commit-Position: refs/heads/master@{#300430}

Powered by Google App Engine
This is Rietveld 408576698