Pass needLocalPath flag to file chooser dialog.

Pass needLocalPath flag to file chooser dialog.

blink::WebFileChooserParams has a flag to show whether the receiver
(WebFileChooserCompletion) needs local paths of files or not.

The CL conveys the flag to the file chooser dialog so that the dialog does not
create snapshot file when the receiver does not need local paths.

BUG=126902
Committed: https://crrev.com/e9f2732be098fb87f17b1b19cd76f357f26cd3f1
Cr-Commit-Position: refs/heads/master@{#300648}

[hirono, 2014-10-21 03:00:19]

Pass needLocalPath flag to file chooser dialog.

blink::WebFileChooserParams has a flag to show whether the receiver
(WebFileChooserCompletion) needs local paths of files or not.

The CL conveys the flag to the file chooser dialog so that the dialog does not
create snapshot file when the receiver does not need local paths.

[hirono, 2014-10-21 03:16:12]

hirono@chromium.org changed reviewers:
+ bbudge@chromium.org, jamesr@chromium.org, nasko@chromium.org,
thestig@chromium.org

[hirono, 2014-10-21 03:16:13]

PTAL at the CL? especially

@thestig
file_select_helper.h

@nasko
content/common/view_messages.h
content/public/common/file_chooser_params.h

@bbudge
content/renderer/pepper/pepper_file_chooser_host.cc

@jamesr
content/renderer/render_view_impl.cc

Thank you!

[Lei Zhang, 2014-10-21 10:42:03]

chrome/ lgtm

https://codereview.chromium.org/663293002/diff/1/content/public/common/file_c...
File content/public/common/file_chooser_params.h (right):

https://codereview.chromium.org/663293002/diff/1/content/public/common/file_c...
content/public/common/file_chooser_params.h:50: bool need_local_path;
You may want to put this in the initializer list, similar to |mode|. Otherwise
future users may easily forget to set this and cause an uninitialized read.

[bbudge, 2014-10-21 13:32:34]

content/renderer/pepper LGTM w/ comment

https://codereview.chromium.org/663293002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_file_chooser_host.cc (right):

https://codereview.chromium.org/663293002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_file_chooser_host.cc:144:
std::vector<blink::WebString> mine_types(accept_mime_types.size());
Would you mind fixing this typo while you're here? s/mine_types/mime_types

[jamesr, 2014-10-21 15:36:28]

lgtm

[nasko, 2014-10-21 15:51:51]

LGTM

[hirono, 2014-10-22 06:43:12]

Thank you!

@bbudge - TBR for params.needLocalPath = true. The flag value was wrong.
PepperFileChooserHost needs local paths. I updated the value.

https://codereview.chromium.org/663293002/diff/1/content/public/common/file_c...
File content/public/common/file_chooser_params.h (right):

https://codereview.chromium.org/663293002/diff/1/content/public/common/file_c...
content/public/common/file_chooser_params.h:50: bool need_local_path;
On 2014/10/21 10:42:03, Lei Zhang wrote:
> You may want to put this in the initializer list, similar to |mode|. Otherwise
> future users may easily forget to set this and cause an uninitialized read.

Done.

https://codereview.chromium.org/663293002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_file_chooser_host.cc (right):

https://codereview.chromium.org/663293002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_file_chooser_host.cc:144:
std::vector<blink::WebString> mine_types(accept_mime_types.size());
On 2014/10/21 13:32:34, bbudge wrote:
> Would you mind fixing this typo while you're here? s/mine_types/mime_types

Done.

[hirono, 2014-10-22 06:43:36]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:43:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663293002/20001

[commit-bot: I haz the power, 2014-10-22 08:06:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-22 08:07:23]

Patchset 2 (id:??) landed as
https://crrev.com/e9f2732be098fb87f17b1b19cd76f357f26cd3f1
Cr-Commit-Position: refs/heads/master@{#300648}