Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 663253006: Various cleanup/simplification in object-observe.js (Closed)

Created:
6 years, 1 month ago by adamk
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews)
Project:
v8
Visibility:
Public.

Description

Various cleanup/simplification in object-observe.js The biggest change is the removal of the map wrapper objects: we now operate directly on the observation weak map, since there are already Get/GetOrCreate/Set functions for each info map. Various other small cleanups as well, including the deletion of unnecessary forwarding functions and making use of standard macros. This is a reland of r24972, retaining GetObservationStateJS() to keep snapshotting working properly. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -73 lines) Patch
M src/object-observe.js View 8 chunks +34 lines, -73 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
6 years, 1 month ago (2014-10-29 16:38:47 UTC) #2
rossberg
lgtm
6 years, 1 month ago (2014-10-29 17:22:27 UTC) #3
adamk
6 years, 1 month ago (2014-10-29 17:27:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698